Skip to content

[master] 2055-Custom_Main_Window#383

Open
memurats wants to merge 13 commits into
masterfrom
nmc/master/custom_main_window
Open

[master] 2055-Custom_Main_Window#383
memurats wants to merge 13 commits into
masterfrom
nmc/master/custom_main_window

Conversation

@memurats
Copy link
Copy Markdown

main window changes

@memurats memurats self-assigned this Oct 27, 2025
@memurats memurats added custom MagentaCLOUD customisation approved build-ready Include into custom client build labels Oct 27, 2025
github-actions Bot pushed a commit that referenced this pull request Oct 28, 2025
@memurats memurats force-pushed the nmc/master/custom_main_window branch 2 times, most recently from f41dc76 to db2545d Compare November 14, 2025 13:12
@memurats memurats added the enhancement New feature or request label Jan 22, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 22, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 22, 2026
@memurats memurats removed the enhancement New feature or request label Jan 23, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 23, 2026
@memurats memurats added the enhancement New feature or request label Jan 26, 2026
github-actions Bot pushed a commit that referenced this pull request Jan 26, 2026
@memurats memurats force-pushed the nmc/master/custom_main_window branch from c39a55a to 7ea6446 Compare January 26, 2026 09:55
@memurats memurats removed the enhancement New feature or request label Feb 4, 2026
github-actions Bot pushed a commit that referenced this pull request Feb 4, 2026
@memurats memurats added approved build-ready Include into custom client build and removed approved build-ready Include into custom client build labels Feb 13, 2026
@memurats memurats added approved build-ready Include into custom client build and removed approved build-ready Include into custom client build labels Feb 24, 2026
@memurats memurats added the enhancement New feature or request label Feb 24, 2026
github-actions Bot pushed a commit that referenced this pull request Feb 24, 2026
@Rello
Copy link
Copy Markdown
Collaborator

Rello commented Mar 20, 2026

Very complex diff to be analyzed

@Rello Rello removed the approved label Mar 20, 2026
@nilsding nilsding requested review from i2h3 and nilsding as code owners March 20, 2026 12:00
@nilsding
Copy link
Copy Markdown
Collaborator

nilsding commented Mar 20, 2026

just pushed a merge commit that resolves the conflicts. The only change in the merge commit is the movement of the (invisible) accountServer EnforcedPlainTextLabel component above the statusLayout:

% git diff --ignore-space-at-eol origin/nmc/master/custom_main_window...nmc/master/custom_main_window src/gui/tray/MainWindow.qml src/gui/tray/UserLine.qml src/gui/tray/TrayWindowHeader.qml
diff --git a/src/gui/tray/UserLine.qml b/src/gui/tray/UserLine.qml
index b3739356e..7cd5ed483 100644
--- a/src/gui/tray/UserLine.qml
+++ b/src/gui/tray/UserLine.qml
@@ -106,6 +106,23 @@ AbstractButton {
                         : userLine.parent.palette.text)
             }
 
+            EnforcedPlainTextLabel {
+                id: accountServer
+                visible: false
+                Layout.fillWidth: true
+                Layout.alignment: Qt.AlignLeft | Qt.AlignTop
+                verticalAlignment: Text.AlignTop
+                text: server
+                elide: Text.ElideRight
+                font.pixelSize: Style.subLinePixelSize
+
+                color: !userLine.parent.enabled
+                    ? userLine.parent.palette.mid
+                    : ((userLine.parent.highlighted || userLine.parent.down) && Qt.platform.os !== "windows"
+                        ? userLine.parent.palette.highlightedText
+                        : userLine.parent.palette.text)
+            }
+
             RowLayout {
                 id: statusLayout
                 Layout.fillWidth: true
@@ -141,23 +158,6 @@ AbstractButton {
                             : userLine.parent.palette.text)
                 }
             }
-
-            EnforcedPlainTextLabel {
-                id: accountServer
-                visible: false
-                Layout.fillWidth: true
-                Layout.alignment: Qt.AlignLeft | Qt.AlignTop
-                verticalAlignment: Text.AlignTop
-                text: server
-                elide: Text.ElideRight
-                font.pixelSize: Style.subLinePixelSize
-
-                color: !userLine.parent.enabled
-                    ? userLine.parent.palette.mid
-                    : ((userLine.parent.highlighted || userLine.parent.down) && Qt.platform.os !== "windows"
-                        ? userLine.parent.palette.highlightedText
-                        : userLine.parent.palette.text)
-            }
         }
 
         Item { // Spacer

The other customisations are unchanged from before apart from the line endings (which is why I ran git diff with --ignore-space-at-eol set).

@sonarqubecloud
Copy link
Copy Markdown

@Rello Rello added the approved label Mar 20, 2026
@memurats memurats force-pushed the nmc/master/custom_main_window branch from 2ce8f80 to 41088b3 Compare April 28, 2026 13:16
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved build-ready Include into custom client build custom MagentaCLOUD customisation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants